[OpenBIOS] [PATCH] ppc: add Apple copyright string

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Fri May 22 12:22:00 CEST 2015


On 22/05/15 11:07, Alexander Graf wrote:

> On 22.05.15 10:48, Mark Cave-Ayland wrote:
>> On 21/05/15 23:37, Alexander Graf wrote:
>>
>>> On 21.05.15 19:44, Cormac O'Brien wrote:
>>>> On 21.05.15 12:18, Alexander Graf wrote:
>>>>> This requires at least a comment saying that the copyright isn't actually on Apple's side.
>>>>
>>>> Any legal things to be aware of here?
>>>>
>>>>> Also, how much of that do they verify?
>>>>
>>>> As best I can tell, it verifies all of "Copyright 1983-2001 Apple
>>>> Computer, Inc.", but it looks like I can add just about anything on
>>>> the end. Suggestions?
>>>>
>>>
>>> How about "Copyright 1983-2001 Apple Computer, Inc. THIS STRING IS ONLY
>>> HERE BECAUSE OF MAC OS 9 COMPATIBILITY, COPYRIGHT IS WITH THE OPENBIOS
>>> PROJECT AND ITS CONTRIBUTORS".
>>
>> We could also try some evil client detection - if we know that only
>> MacOS uses the adler32 word, we could patch it to also update the
>> copyright string at the root node of the device tree which won't be
>> user-visible from Forth as the bootloader has already executed ;)
> 
> I like the idea ;). The respective code could get a big fat comment
> explaining why we do the hack.

Yeah indeed. The convention in Forth is to surround the "implementation"
word in parentheses so I would suggest something like this in
arch/ppc/qemu/qemu.fs:

: adler32  ( a b c -- d e f )
  ... hack and comment for copyright string ..
  (adler32)

And then rebind the existing adler32 C implementation to (adler32)
instead (which also allows for testing). Over to Cormac again for
testing and implementation :)


ATB,

Mark.




More information about the OpenBIOS mailing list