[OpenBIOS] [Patch] Add rom node to device tree

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Sun May 3 23:31:46 CEST 2015


On 02/05/15 07:43, Programmingkid wrote:

> This patch adds the rom node to the device tree for powerpc only. This node
>  is needed by Mac OS 9. Adding this patch allowed for Mac OS 9 to 
> boot further than before. 
> 
> This is the forth code in the Mac OS ROM file that OpenBIOS would call:
> " /rom" find-device
> 
> When the /rom node couldn't be found, booting would just die at that code.
> 
> Signed-off-by: John Arbuckle <programmingkidx at gmail.com>
> 
> Index: arch/ppc/qemu/tree.fs
> ===================================================================
> --- arch/ppc/qemu/tree.fs	(revision 1335)
> +++ arch/ppc/qemu/tree.fs	(working copy)
> @@ -42,6 +42,11 @@
>  	: close ;
>  finish-device
>  
> +new-device
> +	" rom" device-name
> +finish-device
> +
> +
>  \ -------------------------------------------------------------
>  \ /packages
>  \ -------------------------------------------------------------

Seems reasonable for me. Cormac, as you have been working in this area,
would you like to review and reply with either further comments or
suitable Tested-by and/or Reviewed-by tags for this patch? :)

Both QEMU and OpenBIOS use the tags given at
https://www.kernel.org/doc/Documentation/SubmittingPatches in order to
track the submission process with the most popular being Reviewed-by,
Tested-by and Signed-off-by. There are plenty of examples available in
either the OpenBIOS archives or the QEMU archives for you to look at,
but also feel free to get in touch directly with myself and Alex if you
have any other questions.


ATB,

Mark.




More information about the OpenBIOS mailing list