[OpenBIOS] [PATCH] ppc: fix stack usage in mmu_claim, mem_claim

Cormac O'Brien i.am.cormac.obrien at gmail.com
Wed Jun 17 22:53:14 CEST 2015


On Wed, Jun 17, 2015 at 3:38 PM, Tarl Neustaedter <tarl-b2 at tarl.net> wrote:
> On 2015-Jun-17 16:33 , Programmingkid wrote:
>> On Jun 17, 2015, at 4:19 PM, Cormac O'Brien wrote:
>>
>>> > The 'phys' argument to mem_claim() and 'virt' argument to mmu_claim() are now
>>> > only popped from the stack if the 'align' argument is provided.
>> What's the reason for doing this?
>
> Presumably to comply with page 127 of IEEE 1275, where "claim" is
> defined to not consume an address argument if an alignment is specified.

Correct, Mark remembered that this hadn't been applied to PPC yet and
it was interfering with Apple's boot script.



More information about the OpenBIOS mailing list