[OpenBIOS] [Patch v3] Add non-standard compiler prefix support

Programmingkid programmingkidx at gmail.com
Thu Apr 30 19:34:35 CEST 2015


On Apr 30, 2015, at 1:23 PM, Segher Boessenkool wrote:

> On Thu, Apr 30, 2015 at 01:00:34PM -0400, Programmingkid wrote:
>>>> select_prefix()
>>>> {
>>>> -    for TARGET in ${1}-unknown-linux-gnu- ${1}-linux-gnu- ${1}-linux- ${1}-elf- ${1}-eabi-
>>>> +    # The user can specify the cross compiler like this: CROSS_COMPILER=ppc-elf- ./switch-arch ppc
>>>> +    for TARGET in ${1}-unknown-linux-gnu- ${1}-linux-gnu- ${1}-linux- ${1}-elf- ${1}-eabi- $CROSS_COMPILER
>>>>    do
>>>>        if type ${TARGET}gcc > /dev/null 2>&1
>>>>        then
>>> 
>>> If the user said what cross compiler they want, why not just trust
>>> him?  Those lines are way too long btw.
>> 
>> That is how Mark prefers this change. I would like to see a -compiler_name option and just be
>> the end of it. ./switch-arch ppc -compiler_name powerpc-elf-gcc-4.0.1 is how it would be used.
> 
> What I mean is, if the user has specified a CROSS_COMPILER, it is
> rather foolish to detect other toolchains (and prefer to use those,
> even).

So you probably prefer the first version of this patch where the select-prefix() 
function would return before going thru the loop. 




More information about the OpenBIOS mailing list