[OpenBIOS] [PATCH] bootinfo_init_program: improve memory allocation efficiency

[Programmingkid]

On Apr 19, 2015, at 3:52 PM, Cormac O'Brien wrote:

> This patch provides a more memory-efficient method of allocating memory for the
> boot script by using the actual script length (including entity translations)
> instead of the file size.
> 
> Signed-off-by: Cormac O'Brien <i.am.cormac.obrien at gmail.com>
> 
> ---
> libopenbios/bootinfo_load.c | 102 +++++++++++++++++++++++++++++---------------
> 1 file changed, 67 insertions(+), 35 deletions(-)
> 
> diff --git a/libopenbios/bootinfo_load.c b/libopenbios/bootinfo_load.c
> index fa9e36b..bd282f4 100644
> --- a/libopenbios/bootinfo_load.c
> +++ b/libopenbios/bootinfo_load.c
> @@ -20,7 +20,7 @@
> #include "libopenbios/ofmem.h"
> #include "libc/vsprintf.h"
> 
> -//#define DEBUG_BOOTINFO
> +#define DEBUG_BOOTINFO

Your patch applied easily for me and it did work. The only problem I found is the
uncommented DEBUG_BOOTINFO macro. I am betting Mark would like to keep
it commented.

> 
> +
> 	/* If the payload is bootinfo then we execute it immediately */
> 	if (scriptvalid) {
> 		DPRINTF("bootscript: %s\n", bootscript);

Is this about where you placed your '\r'->'\n' hack? Could you please send me it?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.openfirmware.info/pipermail/openbios/attachments/20150419/4f2c8e6e/attachment.html>