[OpenBIOS] [PATCH 0/4] Move interrupt mapping routines to post-PCI bus scan

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Fri Nov 14 20:21:43 CET 2014

On 13/11/14 18:21, Alexander Graf wrote:

> On 11/13/14 13:19, Mark Cave-Ayland wrote:
>> This patch fixes up a regression with virtio not working under the latest
>> OpenBIOS SPARC64.
>> The error was introduced by the new interrupt routing code which needs to
>> generate interrupt-map properties based upon the current active PCI slot
>> (previously the OS would determine this automatically as the properties
>> weren't present in the device tree).
>> In its current form, the code works by hard-coding the slots for the
>> network and disk devices; however this fails to map the interrupt for
>> devices added at QEMU runtime via device such as virtio.
>> This patchset fixes this problem in the following way:
>> 1) Move the PCI host interrupt setup from out of the per-device host
>> bridge callback (called generally towards the start of the PCI bus scan)
>> and into a separate function called after the entire PCI bus has been
>> scanned
>> 2) Add code to dynamically generate the interrupt-map property for
>> slots containing devices with an interrupt pin once the PCI bus scan
>> is complete
>> 3) As a bonus: tidy up the openpic interrupt mapping into the same
>> routine
>> I believe there is a strong case for getting this patchset into the
>> upcoming QEMU 2.2 release, so please let me know if there are any
>> great objections.
> Acked-by: Alexander Graf <agraf at suse.de>
> Alex

Thanks! I've just committed the slightly-less-squashed version to SVN
trunk (which has an identical end result) and will send a pull request
for QEMU 2.2 tomorrow.



More information about the OpenBIOS mailing list