[OpenBIOS] [PATCH 2/2] arch/ppc/qemu: simplify MMU exception handlers

[Alexander Graf]

On 29.05.14 01:09, BALATON Zoltan wrote:
> On Thu, 29 May 2014, Alexander Graf wrote:
>> On 28.05.14 21:07, BALATON Zoltan wrote:
>>> Remove duplicated code from the handlers for DSI and ISI exceptions.
>>>
>>> Signed-off-by: BALATON Zoltan <balaton at eik.bme.hu>
>>
>> I can't say I'm a big fan of this patch. Jumping from one handler 
>> into another is a big red flag to me. If you really think it's worth 
>> to consolidate these 3 instructions, please create a separate 
>> call_exception_handler function that you call from the DSI and ISI 
>> handler.
>
> This is assembly and these are not functions but labels. Jumping to 
> the next instruction (like the b exception_return before the 
> exception_return: label) is silly.

Have you ever tried to maintain assembly code that wasn't trying really 
really hard to give you a good level of readability? :)


Alex