[OpenBIOS] [PATCH 0/4] Changes for MorphOS

[Mark Cave-Ayland]

On 08/03/14 01:26, BALATON Zoltan wrote:

> Thanks. I now have these patches in my tree that are not yet merged:
>
> 1. patch 4 you mentioned above
>
> 2. Change the device device name in openbios-devel/forth/device/tree.fs
> to device-tree
> Not sure what was the consensus of the review for this one.
>
> 3. In openbios-devel/libopenbios/client.c fix debug output:
> } else if (strcmp(service, "nextprop") == 0) {
> printk(FMT_prom_arg "\n", pb->args[pb->nargs]);
> - memdump(arg2pointer(pb->args[2]), pb->args[pb->nargs]);
> + memdump(arg2pointer(pb->args[2]), 32);
> } else if (strcmp(service, "setprop") == 0) {
> printk(FMT_prom_arg "\n", pb->args[pb->nargs]);
> Provided by Olivier Danet here:
> http://www.openfirmware.info/pipermail/openbios/2014-March/008146.html

This patch looks fine, so I've just applied this to the main repository 
(with credit to Oliver).

> 4. A new one that adds tlb-sets, tlb-size and bus-frequency properties
> in openbios-devel/arch/ppc/qemu/init.c but only for G4 and I'm not sure
> if they are really needed but these fill in some values in MorphOS debug
> log.
>
> What to do with these?

I would say do a separate patchset with patches 1 and 4 with CC to the 
PPC maintainers (Alex and Andreas) and make sure that they are happy 
with the changes.

Patch 2 is little more tricky; I'd be tempted to move the "OpenBIOS" 
version to another property in the root node of the tree and set it to 
"device-tree" for compatibility reasons. Then again I'm finding it quite 
hard to justify jumping through these sorts of hoops for an OS whose 
developers are so actively hostile :/


ATB,

Mark.