[OpenBIOS] "next-property" reloaded !
Mark Cave-Ayland
mark.cave-ayland at ilande.co.uk
Wed Mar 5 01:03:06 CET 2014
On 04/03/14 20:57, Olivier Danet wrote:
> Just push the one-liner Forth patch I submitted two months ago...
Okay... I think I understand this a bit better now. According to grep
there are only 2 Forth references to next-property in the source tree:
forth/admin/devices.fs
forth/system/ciface.fs
Now we know next-property in ciface.fs can never be called with a
non-existent property, since the check further up the code will detect
this first and exit.
Similarly the loop in devices.fs (.properties) starts from the first
property in the package and loops through them in turn, so again it is
impossible to call next-property with a non-existent property here.
On this basis, given that the patch causes no regressions in my SPARC32
test images I've applied it to SVN trunk - thanks for the patch, and
apologies for the delay in getting it applied.
ATB,
Mark.
More information about the OpenBIOS
mailing list