[OpenBIOS] [PATCH v2] Add USB OHCI + HID driver

Programmingkid programmingkidx at gmail.com
Fri Jun 6 14:58:31 CEST 2014


On Jun 1, 2014, at 5:55 PM, BALATON Zoltan wrote:

> /* Normalize bInterval to log2 of microframes */
> +static int
> +usb_decode_interval(const int speed, const endpoint_type type, const unsigned char bInterval)
> +{
> +#define LOG2(a) ((sizeof(unsigned) << 3) - __builtin_clz(a) - 1)
> +	switch (speed) {
> +	case LOW_SPEED:
> +		switch (type) {
> +		case ISOCHRONOUS: case INTERRUPT:

Could you place each case on its own separate line please.


> +		switch (type) {
> +		case ISOCHRONOUS: case INTERRUPT:
> 

> +	case SUPER_SPEED:
> +		switch (type) {
> +		case ISOCHRONOUS: case INTERRUPT:

These cases should be on their own separate lines also.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.openfirmware.info/pipermail/openbios/attachments/20140606/7ca4cc9c/attachment-0001.html>


More information about the OpenBIOS mailing list