[OpenBIOS] [PATCH] Add USB OHCI + HID driver

[Segher Boessenkool]

> (Could you please cc me on replies? I'm not getting mails from the list 
> due to a configuration problem beyond my control so I can only reply by 
> copying from list archives.)

Talk to the mailing list administrators; the mailing list sets headers
so that "reply to all" will only send to the list.  It's a big nuissance.

> Actually now that I look for it I've found some code in openbios that 
> matches that brige in pci_database.c:PCIbrg_devices[] but it only seems to 
> add its path to /aliases/bridge and does no configuration. I'm not sure 
> that's enough to make it work on real hardware.

The code that configures bridges should look at class code, not device
id, to find the bridges.

> >I can't test on real hardware. The ohci driver is only used if an Apple
> >Keylargo OHCI controller is detected that is fairly specific to mac99
> >machines where the current code probably does not work now due to the
> >bridge issue above. So did I miss something?
> 
> >Hrm?  The USB OHCI is just a standard USB OHCI, used on way more machines
> >than just Apple kit.
> >
> >Now I'm confused :-)
> 
> USB OHCI may be standard but devices that match PCI_VENDOR_ID_APPLE, 
> PCI_DEVICE_ID_APPLE_KEYL_USB are not usually found in other hardware and 
> this is what my patch added.

OHCI controllers should be found by class code, too.

> >Anyway, if the code is truly in such an abominable state that it does
> >not work at all on hardware, just try to make sure it does keep working
> >wherever it does now work.  And write clean code, no awful hacks,
> 
> I don't know if it works on hardware or not but the code I've added is 
> only called for devices matching the above IDs so I think it should not 
> break anything else than Macs where I don't know anyone using or even 
> tried OpenBIOS.
> 
> >certainly no awful hacks that cross boundaries and/or are not well
> >documented, that kind of thing.  Leave it in a better state than it was
> >in originally and one day we will have something great ;-)
> 
> I try my best but how about not leaving it in a worst state than it was 
> instead? :-)

I think you'll find you have a much easier time getting your patch accepted
if it actually *improves* things ;-)


Segher