[OpenBIOS] [PATCH] Building OpenBIOS on Mac OS X

Segher Boessenkool segher at kernel.crashing.org
Fri May 10 02:09:35 CEST 2013


> "hw.cpu64bit_capable: 1" can mean ppc64 just as well on 10.5, so it
> would be best to check for Darwin 64-bitness *after* the original  
> `uname
> -m` architecture sanitization.

It also doesn't exist before 10.5; on 10.4 you test for 64-bit
differently.

>> -    for TARGET in ${1}-unknown-linux-gnu- ${1}-linux-gnu- ${1}- 
>> linux- ${1}-elf- ${1}-eabi-
>> +    for TARGET in ${1}-unknown-linux-gnu- ${1}-linux-gnu- ${1}- 
>> linux- ${1}-elf- ${1}-eabi- ppc-elf-
>
> This has nothing to do with Mac OS X and thus, if we want this at all,
> belongs in a separate patch. git-svn can help with that.
>
> I think it is wrong that you are hardcoding ppc here, so it will fall
> back to ppc-elf- prefix for sparc, etc. as well. powerpc-elf-  
> prefix is
> covered by ${1}-elf- here, so you'd need to check the call sites of
> select_prefix() instead.

And again, ppc-elf- is just a random made-up name.


Segher




More information about the OpenBIOS mailing list