[OpenBIOS] [PATCH 03/16] terminal.fs: Fix linefeeds on the bottom line of the Forth console.
segher at kernel.crashing.org
Mon Mar 11 18:36:57 CET 2013
Nice series. Time to nitpick...
> --- a/openbios-devel/forth/device/terminal.fs
> +++ b/openbios-devel/forth/device/terminal.fs
> @@ -230,6 +230,12 @@
> a of \ LF
> line# 1+ to line# 0 to column#
> + line# #lines >= if
> + line# 1-
> + 0 to line#
> + 1 delete-lines
> + to line#
> + then
This code does not handle the case when line# > #lines (should probably
be an unsigned comparison anyway, as always); so make the test test for
equality only? Or actually handle it, if that is useful?
More information about the OpenBIOS