[OpenBIOS] new world (qemu -mac99), double nvram entry

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Tue Jan 29 23:03:43 CET 2013


On 28/01/13 11:35, Amadeusz Sławiński wrote:

> When looking at qemu -mac99 I noticed that there are two nvram entries in openbios:
>
> The first one (nvram at fff04000) has initialized .properties while the
> other one has words.
>
> 0>  dev / ls
> ...
> fff75e24 pci at f2000000
> fff77848 nvram at fff04000
> fff778e0 nvram
>   ok
> 0>  dev /nvram at fff04000  ok
> 0>  words
>   ok
> 0>  .properties
> name                      "nvram"
> #bytes                    2000
> reg                       fff04000   00004000
> device_type               "nvram"
> compatible                "nvram,flash"
>   ok
> 0>  dev /nvram at 0  ok
> 0>  words close open seek write read size
>   ok
> 0>  .properties
> name                      "nvram"
>   ok
>
> Attached patch fixes initialization, so only one node is created
> containing both .properties and words.
>
> 0>  dev / ls
> ...
> fff75e24 pci at f2000000
> fff77868 nvram at fff04000
>   ok
> 0>  dev /nvram at fff04000  ok
> 0>  words close open seek write read size
>   ok
> 0>  .properties
> name                      "nvram"
> #bytes                    2000
> reg                       fff04000   00004000
> device_type               "nvram"
> compatible                "nvram,flash"
>   ok
>
> Signed-off-by: Amadeusz Sławiński<amade at asmblr.net>

This patch looks good to me. Can you resubmit with a comment in exactly 
the same style as the existing entries in "git log" and then I can apply it?


Many thanks,

Mark.



More information about the OpenBIOS mailing list