[OpenBIOS] [PATCH] ESP : Debug SCSI command

Blue Swirl blauwirbel at gmail.com
Sun Jan 20 16:58:43 CET 2013


On Sun, Jan 20, 2013 at 3:23 PM, Mark Cave-Ayland
<mark.cave-ayland at ilande.co.uk> wrote:
> On 17/01/13 20:32, Blue Swirl wrote:
>
>> On Mon, Jan 14, 2013 at 9:26 PM, Olivier DANET<odanet at caramail.com>
>> wrote:
>>>
>>> [PATCH] ESP : Debug SCSI command
>>
>>
>> Please drop this line in the future.
>>
>>> The SCSI command code is at position 1, the first byte is the message_out
>>> byte (=0x80, constant)
>>>
>>> diff a/openbios-devel/drivers/esp.c b/openbios-devel/drivers/esp.c
>>> --- a/openbios-devel/drivers/esp.c
>>> +++ b/openbios-devel/drivers/esp.c
>>> @@ -106,7 +106,7 @@ do_command(esp_private_t *esp, sd_privat
>>>       // Clear interrupts to avoid guests seeing spurious interrupts
>>>       (void)esp->ll->regs[ESP_INTRPT];
>>>
>>> -    DPRINTF("do_command: id %d, cmd[0] 0x%x, status 0x%x\n", sd->id,
>>> esp->buffer[0], status);
>>> +    DPRINTF("do_command: id %d, cmd[0] 0x%x, status 0x%x\n", sd->id,
>>> esp->buffer[1], status);
>>>
>>>       /* Target didn't want all command data? */
>>>       if ((status&  ESP_STAT_TCNT) != ESP_STAT_TCNT) {
>>>
>>>
>>>
>>> Signed-off-by: Olivier DANET<odanet at caramail.com>
>>
>>
>> See the other message.
>>
>> Otherwise the patch is correct.
>
>
> Do you want me to tidy up and commit these patches? I'm happy to do that
> with the Signed-off-by.

That would be most kind of you, thank you.

>
>
> ATB,
>
> Mark.



More information about the OpenBIOS mailing list