[OpenBIOS] [PATCH] Remove zero page mapping from all architectures to allow detection of NULL pointer dereferences.

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Wed Apr 10 01:12:57 CEST 2013


On 09/04/13 21:00, Artyom Tarasenko wrote:

> You seem not to like my
>
> #define LOWMEM_START PAGE_SIZE
>
> ? I think it would have made distinguishing between the page size and
> the offset parameters more obvious.

When I took a look at your patch, I felt that with a comment and 
PAGE_SIZE on its own that it was fairly obvious what was happening (as I 
can't see it being something that people would want to keep changing). I 
don't feel overwhelmingly strongly about it, so if you or anyone else 
feel there is a good case for doing it that way then I'm happy to be 
persuaded.

I think the most important thing at the moment is to work out why 
SPARC64 dereferences a NULL pointer during PCI enumeration though :/


ATB,

Mark.



More information about the OpenBIOS mailing list