[OpenBIOS] [PATCH] Replace 'Qemu' by 'QEMU'

Stefan Weil sw at weilnetz.de
Sun May 20 22:36:53 CEST 2012


Am 20.05.2012 18:11, schrieb Andreas Färber:
> Am 12.05.2012 14:00, schrieb Stefan Weil:
>> The official product name is written 'QEMU'.
>>
>> Signed-off-by: Stefan Weil <sw at weilnetz.de>
>
> Thanks, applied all changes to comments in r1060.
>
>> diff --git a/drivers/pci_database.c b/drivers/pci_database.c
>> index ac47621..0983da3 100644
>> --- a/drivers/pci_database.c
>> +++ b/drivers/pci_database.c
>> @@ -176,7 +176,7 @@ static const pci_dev_t vga_devices[] = {
>> },
>> {
>> PCI_VENDOR_ID_QEMU, PCI_DEVICE_ID_QEMU_VGA,
>> - NULL, "QEMU,VGA", "Qemu VGA", "VGA\0",
>> + NULL, "QEMU,VGA", "QEMU VGA", "VGA\0",
>> 0, 0, 0,
>> NULL, NULL,
>> },
>
> I wonder if changing this string here would be guest-visible or just for
> debugging purposes in OpenBIOS?
>
> Andreas
>

That's the model part of the PCI device structure.
The model is exposed as a property in function ob_pci_add_properties,
so I think it is visible for OpenBIOS Forth code.

AFAIK the operating system can access OpenBIOS properties,
so it is visible there, too. That change could break existing code,
but I estimate that the risk is low, and fixing broken code would be 
trivial.

Stefan




More information about the OpenBIOS mailing list