[OpenBIOS] [PATCH] Adds filll (3 l's) to dictionary

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Tue Dec 4 22:53:59 CET 2012


On 04/12/12 00:55, Programmingkid wrote:

> Ok, I finally figured out how to include cross.h. Does this code look good?

That looks much better. However if kernel/cross.h has be included in 
this way then it looks like this is an abstraction that shouldn't be 
broken...

(goes and looks)

Ha so the definition of write_long() looks like this:

#define write_long(addr, value)  {*(u32 *)(addr)=(value);}

Okay in that case I think out of the two methods, your first version is 
more preferable to ensure that the kernel abstraction remains. I'll do 
some more testing, a little tidying, and queue it up for commit if it 
looks good.


ATB,

Mark.



More information about the OpenBIOS mailing list