[OpenBIOS] [PATCH] Adds filll (3 l's) to dictionary

[Mark Cave-Ayland]

On 03/12/12 21:05, Programmingkid wrote:

>> Compare the formatting of your for() statement above with the others in the file - you should use the existing style in your patch.
>
> I was never a fan of that style, but ok.

In general, writing patches is like repairing holes in a plaster wall - 
the aim is to blend your patch in with what is already there so it's 
impossible to work out where the patch begins/ends without reading the 
SVN log.

>> Also as per my comment on your last version of the patch, you need to use target_long() as per the existing code in lstore.
>
> Do you mean write_long()? This is what lstore uses. Why use this function as oppose to the code I have now?

Oh sorry - yes, you are correct, it is write_long(). Mainly for two 
reasons: 1) to preserve style and 2) ensure that cross-compilation works 
correctly.


ATB,

Mark.