[OpenBIOS] [PATCH] Adds get-key-map to keyboard node
Mark Cave-Ayland
mark.cave-ayland at ilande.co.uk
Mon Dec 3 21:32:43 CET 2012
On 30/11/12 21:57, Programmingkid wrote:
>> Again - please take the get-key-map routine in arch/ppc/mol/methods.c as a starting point and make the *minimum* alterations for it to work under QEMU, and repost the patch. It should be just a case of changing the key detection functions, and so in that case I'd be happy to accept it as a patch.
>
> What advantage would this code have over mine?
It's not an advantage per se, it's to do with maintainability. If the
codebases are similar then any bugfixes to your code can be applied to
the MOL code with relative ease (and while I'm not convinced people are
still using it, I'd like to not break it if possible).
> A problem with this code is it was made for virtualization in mind. Qemu will be "emulating" a PowerMac. What this means is detecting the command key isn't possible with this code as is. My code already handles this situation.
Are you sure about this? I'd be surprised if there wasn't already some
kind of workaround in place. As mentioned before, OpenBIOS is designed
to be able to run on real hardware with minimal modifications and so I'm
not greatly keen to do this. Have you asked the developers on the
qemu/qemu-ppc mailing lists how to emulate the command key on a non-Mac?
ATB,
Mark.
More information about the OpenBIOS
mailing list