[OpenBIOS] [PATCH] make select-dev and unselect-dev compatible with OBP
mark.cave-ayland at siriusit.co.uk
Fri Aug 5 16:41:21 CEST 2011
On 05/08/11 15:29, Bob Breuer wrote:
>> I've applied this patch locally and tested it on my various SPARC32
>> images and everything seems to work fine. My only minor niggle is that
>> logically I would expect all of the package words to be in
>> forth/admin/devices.fs rather than forth/debugging/fcode.fs.
> Both begin-package and end-package were already in
> forth/debugging/fcode.fs. This is mostly just code movement/refactoring
> so I moved select-dev/unselect-dev to where most of the code already
> was. Let me know if you want it another way. None of the words that I
> changed are used anywhere within OpenBIOS itself.
>> However... reading the IEEE 1275 specification once again I found this
>> on page 251 (Section H.8): "The following user interface command names
>> have changed from their pre-Open Firmware versions, with no change in
>> behavior" and select-dev/unselect-dev are listed below. Hmmm. This seems
>> to disagree with the original intent of the patch. Anyone have any
>> further thoughts on this?
> See the errata for section H.8. Also see the "Debugging and Testing
> Fcode Programs" section of "Writing FCode 3.x Programs" at
> which shows the simpler OBP definitions for begin-package/end-package
> along with descriptions of select-dev/unselect-dev. Maybe I should add
> this extra detail to the patch description and source comments.
Ah got it - in the core errata at
and unselect-dev have been removed from this list.
In that case, if you can move the commands from forth/debugging/fcode.fs
to forth/admin/devices.fs and update the commit comment to reflect this
then I'm happy with the patch.
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
t: +44 870 608 0063
Sirius Labs: http://www.siriusit.co.uk/labs
More information about the OpenBIOS