[OpenBIOS] [commit] r868 - trunk/openbios-devel/libopenbios

repository service svn at openbios.org
Wed Sep 29 18:27:42 CEST 2010

Author: mcayland
Date: Wed Sep 29 18:27:42 2010
New Revision: 868
URL: http://tracker.coreboot.org/trac/openbios/changeset/868

When DEBUG_CIF is defined, a serial message of the form "method(...) = "
is emitted by dump_service(). After successful execution the return value
and a linebreak are emitted by dump_return(). If however the method fails,
nothing is emitted, so that subsequent method calls end up in place of the
return value. Observed for getproplen with AIX.

Emit an error indication and a linebreak when DEBUG_CIF is defined.

Signed-off-by: Andreas Färber <andreas.faerber at web.de>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at siriusit.co.uk>


Modified: trunk/openbios-devel/libopenbios/client.c
--- trunk/openbios-devel/libopenbios/client.c	Tue Sep 28 20:59:47 2010	(r867)
+++ trunk/openbios-devel/libopenbios/client.c	Wed Sep 29 18:27:42 2010	(r868)
@@ -306,6 +306,10 @@
 		if( val == -1 )
 			printk("Unimplemented service %s ([%ld] -- [%ld])\n",
 			       pb->service, pb->nargs, pb->nret );
+#ifdef DEBUG_CIF
+		else
+			printk("ERROR!\n");
 		return -1;

More information about the OpenBIOS mailing list