[OpenBIOS] [PATCH] fcode-utils: Add type support for Haiku

Andreas Färber andreas.faerber at web.de
Sun Sep 19 23:01:58 CEST 2010


Am 19.09.2010 um 22:10 schrieb Stefan Reinauer:

> On 9/19/10 7:11 PM, Andreas Färber wrote:
>> Haiku does not have asm/types.h. It does have [u]int*_t but not
>> in sys/types.h. Use stdint.h instead, that works for both Haiku and
>> OpenSolaris and avoids more code duplication in shared/types.h.
>> Signed-off-by: Andreas Färber<andreas.faerber at web.de>
>> Cc: Stefan Reinauer<stepan at openbios.org>
> Thanks for spotting this and sending a patch!
> Hm.. I'm just wondering... shouldn't we instead use stdint.h for all  
> platforms? It's there at least on all C99 compilers (see section  
> 7.18).. I think we can stop caring too much for platforms with more  
> than 10yr old compilers (that, in addition, don't come with stdint.h  
> anyways)

I'd agree, I just thought there must be some reason not to do that. :)

On platforms that don't define them we could still #ifdef the #include  
out and supply appropriate [u]int*_t typedefs when the need arises.


More information about the OpenBIOS mailing list