[OpenBIOS] [RFC 5/5] Don't make assumptions about device address size

Andreas Färber andreas.faerber at web.de
Sat Oct 30 22:21:08 CEST 2010


Am 27.10.2010 um 21:53 schrieb Blue Swirl:

> On Tue, Oct 26, 2010 at 11:08 PM, Andreas Färber <andreas.faerber at web.de 
> > wrote:
>> v2:
>> * Use phys_addr_t.
>
> Looks OK. Again, it would be nice to make inline functions of CTRL and
> DATA macros in escc.c

These macros are being used on the left side. We'd have to dump the  
whole concept then, duplicating the conversions in separate in and out  
functions - I fail to see the advantage here...

Andreas

> as well as in/out macros in include/arch/*/io.h,
> but that can be done later.
>
> -- 
> OpenBIOS                 http://openbios.org/
> Mailinglist:  http://lists.openbios.org/mailman/listinfo
> Free your System - May the Forth be with you




More information about the OpenBIOS mailing list