[OpenBIOS] [RFC 5/5] Don't make assumptions about device address size

Andreas Färber andreas.faerber at web.de
Sat Oct 30 18:52:34 CEST 2010


Am 27.10.2010 um 21:53 schrieb Blue Swirl:

> On Tue, Oct 26, 2010 at 11:08 PM, Andreas Färber <andreas.faerber at web.de 
> > wrote:
>> v2:
>> * Use phys_addr_t.
>
> Looks OK. Again, it would be nice to make inline functions of CTRL and
> DATA macros in escc.c as well as in/out macros in include/arch/*/io.h,
> but that can be done later.

Applied remaining ppc64 patches in r930-r933.

Some prettifications remain to be evaluated. Will look into the above  
suggestion later tonight.

Current ppc64 build progress should be:

   CC    target/kernel/primitives.o
cc1: warnings being treated as errors
In file included from ../kernel/primitives.c:25:
../kernel/internal.c:53: warning: cast from pointer to integer of  
different size
../kernel/internal.c:53: error: initializer element is not constant
../kernel/internal.c:53: error: (near initialization for 't[2]')
make: *** [target/kernel/primitives.o] Error 1

This is the trampoline initialization issue.

Also still unsolved is the ppc64 relocation issue in start.S. Ideas  
welcome.

Not to mention of course that some assembler code will need to be  
changed for things to work properly at runtime.

Cheers,
Andreas


More information about the OpenBIOS mailing list