[OpenBIOS] [PATCH 3/3] Don't assume that pointer and cell size are identical
agraf at suse.de
Wed Oct 20 10:04:59 CEST 2010
On 18.10.2010, at 13:28, Mark Cave-Ayland wrote:
> Andreas Färber wrote:
>> I've compile-tested ppc, ppc64, sparc32, sparc64; they all appeared to boot
>> as before now (Haiku, AIX, Debian, Solaris, Milax guests).
> That's a good sign :) I'm happy with the patch in principle, but probably Blue/Alex should have the main say on this one.
The changes look pretty mechanical, so I don't think there's too much chance to break things. What we really need is a set of test images + cases to verify that everything still works. Preferably automated far enough to run automatically after every commit for easy bisecting.
Also, looking at the amount of work Andreas is putting into OpenBIOS atm, wouldn't it make sense to give him commit rights? Larger changes could still go through RFC cycles, but for mechanical parts I'm not sure the peer review is all that helpful.
More information about the OpenBIOS