[OpenBIOS] [commit] r976 - in trunk/openbios-devel: arch/ppc/qemu include/arch/ppc

[Andreas Färber]

Am 28.11.2010 um 14:12 schrieb Blue Swirl:

> On Sun, Nov 28, 2010 at 1:05 PM, Andreas Färber <andreas.faerber at web.de 
> > wrote:
>> Am 28.11.2010 um 12:56 schrieb Blue Swirl:
>>
>>> On Sun, Nov 28, 2010 at 11:40 AM, repository service <svn at openbios.org 
>>> >
>>> wrote:
>>>>
>>>> Author: afaerber
>>>> Date: Sun Nov 28 12:40:42 2010
>>>> New Revision: 976
>>>> URL: http://tracker.coreboot.org/trac/openbios/changeset/976
>>>>
>>>> Log:
>>>> ppc: Create function descriptors for global functions on ppc64
>>>>
>>>> This should also fix linker errors observed by Blue.
>>>
>>> Not yet:
>>>  LINK  openbios-qemu.elf
>>> libdrivers.a(timer.o): In function `udelay':
>>> /src/openbios-devel/obj-ppc64/../drivers/timer.c:91: undefined
>>> reference to `._wait_ticks'
>>>
>>> How about this change (get_ticks is not used elsewhere, no need to  
>>> export
>>> it):
>>
>> It's documented as a C function in the comment above and may get  
>> handy later
>> on, so I'd prefer to change the calling code.
>
> Then it should be declared in some C header. It's like forgetting to
> use 'static' in C.
>
>> Mind to check and add your Tested-by?
>
> I sent an Acked-by, though it also passed my compile test, so feel
> free to change that to Tested-by or even add both.
>
>>> diff --git a/arch/ppc/timebase.S b/arch/ppc/timebase.S
>>> index c519511..38d2566 100644
>>> --- a/arch/ppc/timebase.S
>>> +++ b/arch/ppc/timebase.S
>>> @@ -4,7 +4,7 @@
>>> /*
>>>  * unsigned long long _get_ticks(void);
>>>  */
>>> -GLOBL(_get_ticks):
>>> +get_ticks:
>>
>> Any technical reason for changing the name? I'd assume it's copied  
>> from
>> Linux or somewhere. __divide_error isn't exactly nice either.
>
> After removing the export, we don't need to use underscore anymore.

So I gather, pure cosmetics. Feel free to commit a rename but please  
update the comment as well.

Andreas