[OpenBIOS] [PATCH v3 1/2] ppc: Adjust isa_io_base for ppc64
andreas.faerber at web.de
Sun Nov 21 14:40:26 CET 2010
Am 21.11.2010 um 14:09 schrieb Alexander Graf:
> On 21.11.2010, at 14:00, Blue Swirl wrote:
>> On Sat, Nov 20, 2010 at 4:42 PM, Andreas Färber <andreas.faerber at web.de
>> > wrote:
>>> Am 13.11.2010 um 10:25 schrieb Andreas Färber:
>>>> To avoid cast warnings, use a 64-bit ISA I/O base on ppc64.
>>>> * Adjust unix target, pointed out by Blue.
>>>> Unify ppc and sparc64, using unsigned long instead of uintptr_t.
>>>> It is initialized from pci_arch_t, which uses unsigned long.
>>>> * Update other ppc targets, pointed out by Blue.
>>> Ping. Opinions on which type is more correct to use here? Should
>>> we go with
>>> uintptr_t and change PCI instead?
>> For Sparc64, isa_io_base should be 64 bits. Any one of unsigned long,
>> uintptr_t or phys_addr_t would be correct. Sparc32 does not use ISA,
>> so that leaves the decision to PPC/PPC64.
> I'm reasonably indifferent. On PPC32 we don't support memory > 32
> bits IIRC. On PPC64, there's the theoretical possibility to have the
> isa base above 32 bits, so anything works really :).
Thanks guys, I went with the least invasive version then and applied
it in r964.
Alex, if you could add an Acked-by or Reviewed-by for the uint16_t
port patch, I'd apply that one as well. Getting closer to SLBs then!
More information about the OpenBIOS