[OpenBIOS] [PATCH v5 3/5] Pretty-print reg property
andreas.faerber at web.de
Fri Nov 12 23:31:20 CET 2010
Am 12.11.2010 um 23:26 schrieb Segher Boessenkool:
>> + " #size-cells" rot get-package-property if 1 exit then
>> + \ we don't have to support more than 4
>> + decode-int nip nip 0 max
> It's not a signed number, so it should be umax, not max.
> But "0 umax" is a noop. Just remove it, use the value
Your loop uses them as signed numbers though...
Your quote also shows a stray comment that I'll remove.
> A sanity check somewhere (probably not here though) might be
> useful; but mangling the data if deemed out-of-range is hiding
> the problem, at best.
> OpenBIOS http://openbios.org/
> Mailinglist: http://lists.openbios.org/mailman/listinfo
> Free your System - May the Forth be with you
More information about the OpenBIOS