[OpenBIOS] [PATCH v5 3/5] Pretty-print reg property

Segher Boessenkool segher at kernel.crashing.org
Fri Nov 12 23:26:07 CET 2010


> +    " #size-cells" rot get-package-property if 1 exit then
> +    \ we don't have to support more than 4
> +    decode-int nip nip 0 max

It's not a signed number, so it should be umax, not max.
But "0 umax" is a noop.  Just remove it, use the value
as-is.

A sanity check somewhere (probably not here though) might be
useful; but mangling the data if deemed out-of-range is hiding
the problem, at best.


Segher




More information about the OpenBIOS mailing list