[OpenBIOS] [PATCH] ppc: Convert IO macros to inline functions

Alexander Graf agraf at suse.de
Thu Nov 11 08:39:00 CET 2010


On 11.11.2010, at 00:01, Andreas Färber <andreas.faerber at web.de> wrote:

> Am 30.10.2010 um 21:51 schrieb Andreas Färber:
> 
>> diff --git a/include/arch/ppc/io.h b/include/arch/ppc/io.h
>> index e5180f2..84198f2 100644
>> --- a/include/arch/ppc/io.h
>> +++ b/include/arch/ppc/io.h
> 
>> +static inline void insw(phys_addr_t port, void *buf, int ns)
>> +{
>> +    _insw((uint16_t *)(port + isa_io_base), buf, ns);
>> +}
> 
> I'm wondering whether the use of phys_addr_t is right here or whether it should be uintptr_t? Would like to get this out of my queue.

PIO only defines 16 bit number of ports anyways, no?


Alex

> 



More information about the OpenBIOS mailing list