[OpenBIOS] [PATCH] Introduce forth_init() for trampoline initialization

Andreas Färber andreas.faerber at web.de
Tue Nov 9 21:42:24 CET 2010

Am 09.11.2010 um 19:57 schrieb Blue Swirl:

> On Tue, Nov 9, 2010 at 6:38 PM, Andreas Färber  
> <andreas.faerber at web.de> wrote:
>> Am 09.11.2010 um 19:07 schrieb Blue Swirl:
>>> On Mon, Nov 8, 2010 at 11:20 PM, Andreas Färber <andreas.faerber at web.de 
>>> >
>>> wrote:
>>>> Move trampoline variable initialization to init_trampoline(),
>>>> like in kernel/bootstrap.c.
>>>> Add calls to a new forth_init() function for each architecture
>>>> to invoke it. Idea courtesy of Blue.
>>> Looks OK. I tried a slightly different approach (attached). I added
>>> Mark's excellent analysis as a comment.
>> General setup_trampoline() idea is fine with me. Please avoid  
>> indentation
>> changes though, you're replacing single tabs with 8 spaces.
> I've always used spaces. Actually I'd like to switch to QEMU coding
> style with 4 spaces, this is how Sparc files are formatted.

I personally prefer tabs but would be fine with 4 spaces as well.
Just, please, don't convert single lines within a differently  
formatted function. That decreases readability.


More information about the OpenBIOS mailing list