[OpenBIOS] [PATCH] Introduce forth_init() for trampoline initialization

Andreas Färber andreas.faerber at web.de
Tue Nov 9 19:30:47 CET 2010


Am 09.11.2010 um 11:35 schrieb Mark Cave-Ayland:

> Andreas Färber wrote:
>
>> Move trampoline variable initialization to init_trampoline(),
>> like in kernel/bootstrap.c.
>> Add calls to a new forth_init() function for each architecture
>> to invoke it. Idea courtesy of Blue.
>> This fixes ppc64 compilation by avoiding a casted self-reference.
>> Cc: Blue Swirl <blauwirbel at gmail.com>
>> Signed-off-by: Andreas Färber <andreas.faerber at web.de>
>
> The basic patch looks fine to me, except that you've missed one of  
> the callers in kernel/bootstrap.c (i.e. I'd rip out the version  
> there and use yours instead).

Careful, bootstrap.c is initializing a different trampoline. That's  
why my init_trampoline() needed to be static. Both will need to be  
initialized.

Andreas


More information about the OpenBIOS mailing list