[OpenBIOS] [PATCH] Convert cell2pointer() and pointer2cell() macros to inline functions

Blue Swirl blauwirbel at gmail.com
Tue Nov 9 18:35:35 CET 2010

On Mon, Nov 8, 2010 at 9:59 PM, Andreas Färber <andreas.faerber at web.de> wrote:
> Blue,
> Am 31.10.2010 um 18:44 schrieb Andreas Färber:
>> Use const void* for pointer2cell() due to const char* arguments.
>> Fix a misuse of pointer2cell().
>> Suggested by Blue.
>> Cc: Blue Swirl <blauwirbel at gmail.com>
>> Signed-off-by: Andreas Färber <andreas.faerber at web.de>
>> ---
> Discussing about #defines elsewhere, are you planning to review this one? If
> not, I'd go ahead and apply it since it found one erroneous caller.

Looks OK.

> The other patch I'm pretty neutral about. Is there a general rule of thumb
> in this fight against macros?

Not really, I just suggested that out of common sense.

More information about the OpenBIOS mailing list