[OpenBIOS] [PATCH] Introduce forth_init() for trampoline initialization

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Tue Nov 9 11:35:55 CET 2010


Andreas Färber wrote:

> Move trampoline variable initialization to init_trampoline(),
> like in kernel/bootstrap.c.
> 
> Add calls to a new forth_init() function for each architecture
> to invoke it. Idea courtesy of Blue.
> 
> This fixes ppc64 compilation by avoiding a casted self-reference.
> 
> Cc: Blue Swirl <blauwirbel at gmail.com>
> Signed-off-by: Andreas Färber <andreas.faerber at web.de>

The basic patch looks fine to me, except that you've missed one of the 
callers in kernel/bootstrap.c (i.e. I'd rip out the version there and 
use yours instead).


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs



More information about the OpenBIOS mailing list