[OpenBIOS] [PATCH] Convert cell2pointer() and pointer2cell() macros to inline functions

Andreas Färber andreas.faerber at web.de
Mon Nov 8 22:59:11 CET 2010


Blue,

Am 31.10.2010 um 18:44 schrieb Andreas Färber:

> Use const void* for pointer2cell() due to const char* arguments.
> Fix a misuse of pointer2cell().
>
> Suggested by Blue.
>
> Cc: Blue Swirl <blauwirbel at gmail.com>
> Signed-off-by: Andreas Färber <andreas.faerber at web.de>
> ---

Discussing about #defines elsewhere, are you planning to review this  
one? If not, I'd go ahead and apply it since it found one erroneous  
caller.

The other patch I'm pretty neutral about. Is there a general rule of  
thumb in this fight against macros?

Andreas


More information about the OpenBIOS mailing list