[OpenBIOS] [RFC] Switch OFMEM to use phys_addr_t for physical addresses

Andreas Färber andreas.faerber at web.de
Sun Nov 7 16:37:52 CET 2010

Am 07.11.2010 um 16:07 schrieb Blue Swirl:

> On Sun, Nov 7, 2010 at 1:46 PM, Andreas Färber  
> <andreas.faerber at web.de> wrote:
>> Am 07.11.2010 um 14:30 schrieb Mark Cave-Ayland:
>>> Andreas Färber wrote:
>>>>> Ah good spot - would FMT_phys_addr_t be a suitable name for  
>>>>> this? I'll
>>>>> make the defaults for SPARC64 and PPC the same as those for ucell.
>>>> Judging by include/arch/ppc/types.h I'd prefer FMT_physaddrt  
>>>> (without the
>>>> trailing _t that makes it look like a type itself).
>>>> QEMU has TARGET_FMT_plx, so we might use FMT_plx (physical long
>>>> hexadecimal?).
>>> I can see the argument for renaming the FMT argument to avoid  
>>> confusion
>>> with proper types, but
>>> introducing TARGET_FMT_plx seems a little excessive.
>> That's why I suggested FMT_plx without the TARGET_ prefix...
> I'd agree.

With what exactly? FMT_plx? Or that being too excessive?

(Still investigating one ppc regression with v1 here, might be QEMU or  
my WIP.)


More information about the OpenBIOS mailing list