[OpenBIOS] Haiku/ppc progress - ofmem_claim misbehavior?

Artyom Tarasenko atar4qemu at googlemail.com
Mon May 24 17:21:03 CEST 2010


2010/5/24 Andreas Färber <andreas.faerber at web.de>:
> Am 24.05.2010 um 16:22 schrieb Stefan Reinauer:
>
>> On 5/24/10 4:18 PM, Andreas Färber wrote:
>>>
>>> +        phys = ofmem_claim_phys_( addr, size, align, 0,
>>> get_ram_size() - 0x00100000 - (2 << 15) - (32 + 32 + 64) * 1024, 1 /*
>>> reverse */ );
>>> +        virt = ofmem_claim_virt_( addr, size, align, 0,
>>> get_ram_size() - 0x00100000 - (2 << 15) - (32 + 32 + 64) * 1024, 1 /*
>>> reverse */ );
>>
>> This kind of yells for a comment explaining what those numbers are.
>
> These are ppc-specific magic numbers in common code where they have no
> business being - please don't apply!
>
> The question is, why does claim overwrite the 0x07ed0000 identity map of
> length 1245184, that I see no in my debug output now, with a 0x07f00000 map
> when using the vanilla OpenBIOS code?
> And do we need to supply platform-specific functions arch_get_ram_top and
> arch_get_ram_bottom, or is my approach just working around the problem?

Not sure if it's a platform-specific problem: on sparc32 with a similar patch
Solaris boot gets a bit further.

-- 
Regards,
Artyom Tarasenko

solaris/sparc under qemu blog: http://tyom.blogspot.com/



More information about the OpenBIOS mailing list