[OpenBIOS] [commit] r855 - in trunk/openbios-devel: arch/sparc32 drivers

repository service svn at openbios.org
Sun Aug 22 11:29:29 CEST 2010


Author: blueswirl
Date: Sun Aug 22 11:29:28 2010
New Revision: 855
URL: http://tracker.coreboot.org/trac/openbios/changeset/855

Log:
Drop some unused variables

Found with this Coccinelle script:
@@
type T;
identifier i;
expression E;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = E;
  ...+>
)

Signed-off-by: Blue Swirl <blauwirbel at gmail.com>

Modified:
   trunk/openbios-devel/arch/sparc32/romvec.c
   trunk/openbios-devel/drivers/pc_kbd.c
   trunk/openbios-devel/drivers/pc_serial.c

Modified: trunk/openbios-devel/arch/sparc32/romvec.c
==============================================================================
--- trunk/openbios-devel/arch/sparc32/romvec.c	Sat Aug 21 12:21:01 2010	(r854)
+++ trunk/openbios-devel/arch/sparc32/romvec.c	Sun Aug 22 11:29:28 2010	(r855)
@@ -197,10 +197,9 @@
 
         return "";
     } else {
-        int len;
         char *str;
 
-        len = POP();
+        POP(); /* len */
         str = (char *) POP();
 
         DPRINTF("obp_nextprop(0x%x, %s) = %s\n", node, name, str);

Modified: trunk/openbios-devel/drivers/pc_kbd.c
==============================================================================
--- trunk/openbios-devel/drivers/pc_kbd.c	Sat Aug 21 12:21:01 2010	(r854)
+++ trunk/openbios-devel/drivers/pc_kbd.c	Sun Aug 22 11:29:28 2010	(r855)
@@ -164,15 +164,12 @@
     int len;
     phandle_t ph;
     unsigned long *prop;
-    char *args;
 
     fword("my-self");
     fword("ihandle>phandle");
     ph = (phandle_t)POP();
     prop = (unsigned long *)get_property(ph, "address", &len);
     *address = *prop;
-    fword("my-args");
-    args = pop_fstr_copy();
 
     RET ( -1 );
 }

Modified: trunk/openbios-devel/drivers/pc_serial.c
==============================================================================
--- trunk/openbios-devel/drivers/pc_serial.c	Sat Aug 21 12:21:01 2010	(r854)
+++ trunk/openbios-devel/drivers/pc_serial.c	Sun Aug 22 11:29:28 2010	(r855)
@@ -145,15 +145,12 @@
     int len;
     phandle_t ph;
     unsigned long *prop;
-    char *args;
 
     fword("my-self");
     fword("ihandle>phandle");
     ph = (phandle_t)POP();
     prop = (unsigned long *)get_property(ph, "address", &len);
     *address = *prop;
-    fword("my-args");
-    args = pop_fstr_copy();
 
     RET ( -1 );
 }



More information about the OpenBIOS mailing list