[OpenBIOS] [commit] r835 - trunk/openbios-devel/drivers

repository service svn at openbios.org
Fri Aug 6 18:49:33 CEST 2010


Author: blueswirl
Date: Fri Aug  6 18:49:32 2010
New Revision: 835
URL: http://tracker.coreboot.org/trac/openbios/changeset/835

Log:
vga_load_regs: check return value for errors

Fixes a warning with GCC 4.0.2:
  CC    target/drivers/vga_load_regs.o
cc1: warnings being treated as errors
../drivers/vga_load_regs.c: In function 'vga_load_regs':
../drivers/vga_load_regs.c:491: warning: 'par.misc' may be used uninitialized in this function

Signed-off-by: Blue Swirl <blauwirbel at gmail.com>

Modified:
   trunk/openbios-devel/drivers/vga_load_regs.c

Modified: trunk/openbios-devel/drivers/vga_load_regs.c
==============================================================================
--- trunk/openbios-devel/drivers/vga_load_regs.c	Fri Aug  6 18:35:44 2010	(r834)
+++ trunk/openbios-devel/drivers/vga_load_regs.c	Fri Aug  6 18:49:32 2010	(r835)
@@ -490,6 +490,7 @@
 {
     struct vga_par par;
 
-    vga_decode_var(&vga_settings, &par);
-    vga_set_regs(&par);
+    if (vga_decode_var(&vga_settings, &par) == 0) {
+        vga_set_regs(&par);
+    }
 }



More information about the OpenBIOS mailing list