[OpenBIOS] r565 - trunk/openbios-devel/modules

[Igor Kovalenko]

On Thu, Sep 3, 2009 at 1:15 AM, Laurent Vivier<Laurent at vivier.eu> wrote:
> Le samedi 22 août 2009 à 08:03 +0200, svn at openbios.org a écrit :
>> Author: blueswirl
>> Date: 2009-08-22 08:03:40 +0200 (Sat, 22 Aug 2009)
>> New Revision: 565
>>
>> Modified:
>>    trunk/openbios-devel/modules/disk-label.c
>> Log:
>> Allow NULL dlabel path argument without accessing page zero.
>>
>> Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
>>
>> Modified: trunk/openbios-devel/modules/disk-label.c
>> ===================================================================
>> --- trunk/openbios-devel/modules/disk-label.c 2009-08-22 06:03:20 UTC (rev 564)
>> +++ trunk/openbios-devel/modules/disk-label.c 2009-08-22 06:03:40 UTC (rev 565)
>> @@ -57,7 +57,7 @@
>>  static void
>>  dlabel_open( dlabel_info_t *di )
>>  {
>> -     char *s, *filename;
>> +     const char *s, *filename;
>>       char *path;
>>       char block0[512];
>>       phandle_t ph;
>> @@ -65,6 +65,9 @@
>>       xt_t xt;
>>
>>       path = my_args_copy();
>> +     if (!path) {
>> +             path = strdup("");
>> +     }
>>       DPRINTF("dlabel-open '%s'\n", path );
>>
>>       /* open disk interface */
>>
>>
>
> This patch breaks booting PPC using QUIK bootloader. Ìs it possible to
> revert it ?
>

Can you please check what is the real issue here?
Maybe dlabel_open is getting called somewhere in bootloader
without proper path argument?

-- 
Kind regards,
Igor V. Kovalenko