[OpenBIOS] PATCH v2: Rework CIF interface to handle parameters in reverse order

Andreas Färber andreas.faerber at web.de
Mon Nov 30 00:20:36 CET 2009


Am 29.11.2009 um 23:09 schrieb Laurent Vivier:

> Le dimanche 29 novembre 2009 à 22:46 +0100, Laurent Vivier a écrit :
>> Le dimanche 29 novembre 2009 à 13:30 +0000, Mark Cave-Ayland a  
>> écrit :
>>> Hi everyone,
>>>
>>> Here is a second version of the patch which attempts to reverse the
>>> argument order of the CIF Forth words so that they can be called
>>> correctly from both Forth and C.
>>>
>>> The patch is fairly straightforward; probably the only unexpected  
>>> part
>>> is the need to rename the existing /openprom/client-services  
>>> "claim" and
>>> "release" words to "cif-claim" and "cif-release" respectively.  
>>> This is
>>> because we need to use the "claim" and "release" words in
>>> forth/system/ciface.fs to reverse the argument order before  
>>> calling the
>>> real underlying words.
>>>
>>> I've tested this on a FC12 PPC CD as well as my SPARC64 Milax CD and
>>> with this version of the patch, the CIF words are called correctly  
>>> in
>>> both cases. I'd like to apply this reasonably soon, so please can  
>>> people
>>> test on their setups to make sure it doesn't break anything?
>>
>> [It works] with:
>>
>> debian-40r6-powerpc-netinst.iso
>> debian-500-powerpc-netinst.iso
>> Fedora-10-ppc-netinst.iso
>> Fedora-11-Preview-ppc-netinst.iso
>> openSUSE-11.1-NET-ppc.iso
>> OpenBSD 4.6

No regressions with these either:

debian-40r4a-powerpc-netinst.iso
Fedora-9-ppc-DVD.iso

some sparc32 Debian GNU/Linux 4.0: Linux debiansparc 2.6.18-6-sparc32  
#1 Thu May 8 07:15:15 UTC 2008 sparc

Andreas




More information about the OpenBIOS mailing list