[OpenBIOS] PATCH: Rework CIF interface to handle parameters in reverse order

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Mon Nov 23 23:36:54 CET 2009


Hi all,

This patch is an attempt at reworking the CIF so that it can be called 
correctly from both Fcode (Forth) and C. Currently the C arguments are 
pushed into the stack in reverse order, rather than forward order which 
is required by Forth words calling the CIF.

In order to fix this, we correct the order in which C arguments are 
placed on the Forth stack by pushing the parameters in forward order. 
However, this has the side effect of reversing the order in which the 
parameters to the CIF Forth words are expected and so these must also be 
altered to take this into account.

This patch works as expected from Forth Fcode, but I would like to put 
it out for testing before I commit to the repository. Blue Swirl/Laurent 
- please can you test on your setups again?


Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at siriusit.co.uk>


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openbios-cif-rework.patch
Type: text/x-diff
Size: 4708 bytes
Desc: not available
URL: <http://lists.openbios.org/pipermail/openbios/attachments/20091123/b6cba2c6/attachment.bin>


More information about the OpenBIOS mailing list