[OpenBIOS] r624 - trunk/openbios-devel/forth/system

[Blue Swirl]

On Sat, Nov 21, 2009 at 1:13 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
> On 11/20/09 11:40 PM, Laurent Vivier wrote:
>> Le vendredi 20 novembre 2009 à 20:09 +0100, svn at openbios.org a écrit :
>>
>>> Author: stepan
>>> Date: 2009-11-20 20:09:04 +0100 (Fri, 20 Nov 2009)
>>> New Revision: 624
>>>
>>> Modified:
>>>    trunk/openbios-devel/forth/system/ciface.fs
>>> Log:
>>> In the IEEE 1275-1994 specification the parameters for Client Interface calls
>>> are not in forth stack order but in reversed (heh!) order. Our implementation
>>> confused this.
>>>
>>> This might / will need some more work, but get this in so more people can test
>>> easily.
>>>
>> This breaks PPC boot. All my ISO disk images (Fedora 10, 11, debian
>> 5.0.0, 4.0r6, openSUSE 11.1, openbsd 4.6, freebsd 7.2 ...) hang. They
>> are yaboot based.
>>
>> My etch HD disk image hangs with this message (it is quik based):
>>
>> call-method AG�@: exception 5401f50
>>
>
> I am very sorry! Can you please try whether the problem goes away by
> just undoing the changes to call-method itself?
>
> In that case we should back them out. Otherwise we should back out the
> whole patch...

It also breaks Sparc64. Undoing just the call-method part does not
help for either PPC or Sparc64, reverting fixes both.