[OpenBIOS] [PATCH] forth: add more pockets

Igor Kovalenko igor.v.kovalenko at gmail.com
Tue May 19 22:53:33 CEST 2009


On Wed, May 20, 2009 at 12:44 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
> On 19.05.2009 22:22 Uhr, Igor Kovalenko wrote:
>> This changes pocket index calculation to support more than two pockets.
>> As an example default number of pockets is set to 4.
>> This should ease nesting more than two levels using pockets as
>> temporary storage.
>>
>> Signed-off-by: Igor Kovalenko <igor.v.kovalenko at gmail.com>
>>
> Very nice! Thank you.
>
> Out of curiosity, did you run into trouble with two pockets? If I
> remember correctly, drivers (ie FCode option roms) or code that is
> supposed to run on other open firmware implementations, too, should not
> assume more than two pockets, but it makes a lot of sense to have enough
> of them.
>

Let's call this forth practice :)
I tried to understand how get-instance-path works and assumed there
may be not enough pockets and created this patch. Other than that,
if pci tree is sufficiently deep you get tmpstrcpy working on
grandparent's data.

-- 
Kind regards,
Igor V. Kovalenko



More information about the OpenBIOS mailing list