[OpenBIOS] [PATCH] Make interrupts work on newworld machines

Andreas Färber andreas.faerber at web.de
Sat Dec 19 00:43:08 CET 2009


Am 18.12.2009 um 23:44 schrieb Alexander Graf:

> Index: drivers/escc.c
> ===================================================================
> --- drivers/escc.c	(revision 644)
> +++ drivers/escc.c	(working copy)
> @@ -418,6 +418,11 @@
>     OLDWORLD(set_property(dnode, "AAPL,interrupts",
>             (char *)&props, 1 * sizeof(cell)));
>
> +    props[0] = 0;
> +    props[0] = (0x24) + offset;

It's probably a stupid question again, but is there a reason to double- 
initialize props[0]? Shouldn't one of them go to a different index or  
the first one be dropped?

Andreas

> +    NEWWORLD(set_property(dnode, "interrupts",
> +             (char *)&props, 2 * sizeof(cell)));
> +
>     device_end();
>
>     uart_init_line((unsigned char*)addr + IO_ESCC_OFFSET + offset *  
> 0x20,
>
> -- 
> OpenBIOS                 http://openbios.org/
> Mailinglist:  http://lists.openbios.org/mailman/listinfo
> Free your System - May the Forth be with you




More information about the OpenBIOS mailing list