[OpenBIOS] [PATCH 2/8] move ppc internal prototypes to arch-specific implementation

Blue Swirl blauwirbel at gmail.com
Sun Aug 2 11:32:37 CEST 2009


On Sun, Aug 2, 2009 at 11:54 AM, Igor
Kovalenko<igor.v.kovalenko at gmail.com> wrote:
>  #define BIT(n)         (1U<<(31-(n)))
>
> +/* called from assembly */
> +extern void dsi_exception( void );
> +extern void isi_exception( void );
> +extern void setup_mmu( ulong code_base );
> +
>  #define FREE_BASE              0x00004000
>  #define IO_BASE                        0x80000000
>  #define OFMEM                  ((ofmem_t*)FREE_BASE)
> Index: openbios-devel/include/ofmem.h
> ===================================================================
> --- openbios-devel.orig/include/ofmem.h
> +++ openbios-devel/include/ofmem.h
> @@ -35,9 +35,6 @@ extern ucell  ofmem_translate( ucell vir
>  ulong get_ram_size( void );
>  ulong get_ram_top( void );
>  ulong get_ram_bottom( void );
> -void dsi_exception( void );
> -void isi_exception( void );
> -void setup_mmu( ulong ramsize );
>  void ofmem_register( phandle_t ph );
>  #elif defined(CONFIG_SPARC32)
>  #define PAGE_SHIFT   12
> Index: openbios-devel/arch/ppc/ofmem.c
> ===================================================================
> --- openbios-devel.orig/arch/ppc/ofmem.c
> +++ openbios-devel/arch/ppc/ofmem.c
> @@ -35,9 +35,9 @@
>  #define BIT(n)         (1U<<(31-(n)))
>
>  /* called from assembly */
> -extern void    dsi_exception( void );
> -extern void    isi_exception( void );
> -extern void    setup_mmu( ulong code_base, ulong code_size, ulong ramsize );
> +extern void dsi_exception( void );
> +extern void isi_exception( void );
> +extern void setup_mmu( ulong code_base, ulong code_size, ulong ramsize );

Can't you use the .h file touched by the first hunk so that these
could be removed?



More information about the OpenBIOS mailing list