[OpenBIOS] r255 - in openbios-devel: arch/ppc/qemu include/openbios modules

[Blue Swirl]

On 11/25/08, Laurent Vivier <laurent at lvivier.info> wrote:
>
>  Le 25 nov. 08 à 17:40, Blue Swirl a écrit :
>
>
>
> > On 11/25/08, Laurent Vivier <Laurent.Vivier at bull.net> wrote:
> >
> > > Le lundi 24 novembre 2008 à 18:59 +0200, Blue Swirl a écrit :
> > >
> > >
> > > > On 11/24/08, svn at openbios.org <svn at openbios.org> wrote:
> > > >
> > > > > Author: stepan
> > > > > Date: 2008-11-24 13:21:36 +0100 (Mon, 24 Nov 2008)
> > > > > New Revision: 255
> > > > >
> > > >
> > > >
> > > > >  void
> > > > > -nvram_init( void )
> > > > > +nvram_init( char *path )
> > > > >
> > > >
> > > > Bad idea, this breaks Sparc32 build.
> > > >
> > >
> > >
> > > I've looked in the device tree of sparc32 and didn't find any entry for
> > > nvram, so is the call to nvram_init() really needed ???
> > >
> >
> > Yes, not for registering it to the device tree, but for reading the
> > config from nvram. The same applies to Sparc64.
> >
> > The function could be changed to check for a NULL (passed to it by
> > Sparc32/64) and perform different actions then, or maybe nvconf_init
> > should be exported and Sparc changed to use it instead of nvram_init.
> >
>
>  IMHO the best thing to fo is to export and call nvconf_init.

OK, I'm testing the attached patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_nvram.diff
Type: plain/text
Size: 2372 bytes
Desc: not available
URL: <http://lists.openbios.org/pipermail/openbios/attachments/20081125/6180665f/attachment.bin>