[OpenBIOS] [PATCH] Fix some unaligned memory accesses

Stefan Reinauer stepan at coresystems.de
Sun Apr 15 02:43:03 CEST 2007


* Paul Brook <paul at codesourcery.com> [070415 02:38]:
> It was accessed through a (uint16_t *) though.

Ooops. I didn't check FAT_CVT_U16 and assumed it would read bytes.

> By taking the address and casting to (uint16_t *) you're hiding the member 
> access, and allowing gcc to assume it is a properly aligned 16-bit value.

Ok. No further tests needed to see the issue. Just checked it in.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/



More information about the OpenBIOS mailing list