[flashrom] Building on Windows with mingw
Antonio Ospite
ao2 at ao2.it
Wed Feb 28 22:19:44 CET 2018
On Wed, 28 Feb 2018 20:31:13 +0100
Miklos Marton <martonmiklosqdev at gmail.com> wrote:
> > diff --git a/flash.h b/flash.h
> > index a80a9c2..40a7f1a 100644
> > --- a/flash.h
> > +++ b/flash.h
> > @@ -360,6 +360,9 @@ int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap
> > /* Let gcc and clang check for correct printf-style format strings. */
> > int print(enum flashrom_log_level level, const char *fmt, ...)
> > #ifdef __MINGW32__
> > +# ifndef __MINGW_PRINTF_FORMAT
> > +# define __MINGW_PRINTF_FORMAT gnu_printf
> > +# endif
> > __attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3)));
> > #else
> > __attribute__((format(printf, 2, 3)));
> >
> >
> > This should be OK because the define is only applied when using MinGW.
> >
[...]
> This method compiles without warnings. Thank you very much!
> Are you planning to submit a patch to flashrom, or should we handle that?
>
I can do it during the week-end.
Ciao,
Antonio
--
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
More information about the flashrom
mailing list